I'm wondering if this would be better suited as a parameter for the "backgroundImage" setting we already have. Such as:

"backgroundImage": "DesktopWallpaper"

@cinnamon-msft I initially tried to implement that, but after talking with Christ-Jan I thought it might be easier on the user to have a setting dedicated for this. A true/false value seems harder to mess up. I could add to the documentation to clarify that if true, it will ignore the "backgroundImage" setting.

Looking into the future with the settings GUI, it would be easier to convert the dedicated setting into the GUI. We could have it as a checkbox which would then remove the option to fill out any other background options if checked. Or some idea along those lines.

With that being said, your suggestion would be less code, which would be easier to maintain. I am open to reworking the issue if the team thinks having a keyword would be more valuable than a dedicated setting.

@cinnamon-msft I initially tried to implement that, but after talking with Christ-Jan I thought it might be easier on the user to have a setting dedicated for this. A true/false value seems harder to mess up. I could add to the documentation to clarify that if true, it will ignore the "backgroundImage" setting.

I disagree with that, actually. Having multiple settings control which background image to use adds more confusion. It makes more sense to just have "backgroundImage" be the direct way to set your background image and go with @cinnamon-msft's plan above. Also, the attached issue says to do that.

Looking into the future with the settings GUI, it would be easier to convert the dedicated setting into the GUI. We could have it as a checkbox which would then remove the option to fill out any other background options if checked.

That's true, but the Settings UI doesn't have to align 1-to-1 with the json. We can still have your proposed GUI implementation, and just edit the JSON accordingly (which is probably what we'll do).

With that being said, your suggestion would be less code, which would be easier to maintain. I am open to reworking the issue if the team thinks having a keyword would be more valuable than a dedicated setting.

Kayla has a good handle on these user-facing issues so I agree with her. I recommend you keep an eye on CascadiaSettings::_ValidateMediaResources() though. You'll probably have to do a check there for this.

@carlos-zamora thanks for the feedback. I have made the changes. I am a bit sad how much easier @cinnamon-msft's implementation was. Would you rather have me update this PR or close and reopen with the new code?

@carlos-zamora thanks for the feedback. I should have the changes implemented fairly quick. Would you rather have me update this PR or close and reopen with the new code?

100% update this PR haha. That way we can track the whole thing more easily. Feel free to reach out to @cinnamon-msft or I if you need any help with anything :). And thanks for the contribution! (should've started with that haha)

@carlos-zamora and @cinnamon-msft both the code and documentation has been updated. Please review both when you have the time. 😄 Documentation: MicrosoftDocs/terminal#155

New misspellings found, please review:

• GETDESKWALLPAPER
• UPDATEINIFILE

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect/alphabet.txt
.github/actions/spell-check/expect/expect.txt
.github/actions/spell-check/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"akb appdata Autogenerated debian debugbreak decf DECLL DECSMBV esa guidgenerator Inplace keith keybound notypeopt openlogo restrictederrorinfo richturn Scs Switchto winver Wlk wslhome "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect/2193bf5de6391931605248cd6092e39f0b988d00.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"autogenerated Debian GETDESKWALLPAPER inplace UPDATEINIFILE WINVER "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check/expect || echo '... you want to ensure .github/actions/spell-check/expect/2193bf5de6391931605248cd6092e39f0b988d00.txt is added to your repository...'

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

@carlos-zamora I believe I have the spell check figured out, but waiting to confirm that. All of your comments should be resolved now

@carlos-zamora Thanks for all the help. @cinnamon-msft would you mind being a second reviewer? I pushed the formatted code.

I'd prefer if someone else from @microsoft/windows-console-team reviewed this since they are more familiar with the codebase.

I'd prefer if someone else from @microsoft/windows-console-team reviewed this since they are more familiar with the codebase.

@cinnamon-msft works for me. I don't know any other devs, so you might have to tag one 😅

Don't worry about the CI failure - that's resolved over in #7930

@zadjii-msft @cinnamon-msft @carlos-zamora @PankajBhojwani
Sounds good. I do not have the ability to merge. So merge it when the team would like to. Appreciate all the help. I learned way more than expected from such a simple ticket. Ill be on the hunt for another issue.

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download